Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to main] Change the ziputil dependency to fix a potential security concern #831

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Mar 27, 2023

Description

This is a backport PR for #824

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
@codecov-commenter
Copy link

Codecov Report

Merging #831 (6554b2e) into main (35dc179) will decrease coverage by 0.28%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #831      +/-   ##
============================================
- Coverage     85.08%   84.80%   -0.28%     
- Complexity     1612     1632      +20     
============================================
  Files           135      135              
  Lines          5973     6082     +109     
  Branches        570      596      +26     
============================================
+ Hits           5082     5158      +76     
- Misses          649      666      +17     
- Partials        242      258      +16     
Flag Coverage Δ
ml-commons 84.80% <80.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/org/opensearch/ml/engine/utils/ZipUtils.java 79.16% <79.16%> (ø)
...a/org/opensearch/ml/engine/algorithms/DLModel.java 85.43% <100.00%> (-0.10%) ⬇️

... and 31 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@b4sjoo b4sjoo merged commit eabfc5b into opensearch-project:main Mar 27, 2023
@b4sjoo b4sjoo deleted the main_bp branch August 18, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants